[
https://issues.apache.org/jira/browse/ARROW-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923032#comment-16923032
]
Wes McKinney commented on ARROW-6428:
-------------------------------------
Here's the first failing build
https://circleci.com/gh/ursa-labs/crossbow/969?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
this is due to the {{arrow::Column}} removal
{code}
-- Generating done
-- Build files have been written to: /tmp/turbodbc/build
[145/156] Building CXX object
cpp/turbodbc_numpy/Library/CMakeFiles/turbodbc_numpy_support.dir/src/set_numpy_parameters.cpp.o
../cpp/turbodbc_numpy/Library/src/set_numpy_parameters.cpp: In function 'void
turbodbc_numpy::set_numpy_parameters(turbodbc::bound_parameter_set&, const
std::vector<std::tuple<pybind11::array, pybind11::array_t<bool, 16>,
std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >
> >&)':
../cpp/turbodbc_numpy/Library/src/set_numpy_parameters.cpp:359:39: warning:
comparison between signed and unsigned integer expressions [-Wsign-compare]
for (std::size_t start = 0; start < total_sets; start +=
parameters.buffered_sets()) {
~~~~~~^~~~~~~~~~~~
[150/156] Building CXX object
cpp/turbodbc_arrow/Library/CMakeFiles/turbodbc_arrow_support.dir/src/set_arrow_parameters.cpp.o
FAILED:
cpp/turbodbc_arrow/Library/CMakeFiles/turbodbc_arrow_support.dir/src/set_arrow_parameters.cpp.o
/usr/bin/g++ -Dturbodbc_arrow_support_EXPORTS -I../cpp/turbodbc_arrow/Library
-I../cpp/turbodbc_arrow/../cpp_odbc/Library
-I../cpp/turbodbc_arrow/../turbodbc/Library -I../pybind11/include -isystem
/opt/conda/include -isystem /opt/conda/include/python3.6m -isystem
/opt/conda/lib/python3.6/site-packages/numpy/core/include -Wall -Wextra -g -O0
-pedantic -fPIC -fvisibility=hidden -std=c++11 -std=c++14 -MD -MT
cpp/turbodbc_arrow/Library/CMakeFiles/turbodbc_arrow_support.dir/src/set_arrow_parameters.cpp.o
-MF
cpp/turbodbc_arrow/Library/CMakeFiles/turbodbc_arrow_support.dir/src/set_arrow_parameters.cpp.o.d
-o
cpp/turbodbc_arrow/Library/CMakeFiles/turbodbc_arrow_support.dir/src/set_arrow_parameters.cpp.o
-c ../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp: In member function
'void
turbodbc_arrow::{anonymous}::string_converter::rebind_to_maximum_length(const
arrow::BinaryArray&, std::size_t, std::size_t)':
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp:101:33: warning:
comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int64_t i = 0; i != elements; ++i) {
~~^~~~~~~~~~~
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp: In member function
'void
turbodbc_arrow::{anonymous}::string_converter::set_batch_utf16(std::size_t,
std::size_t)':
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp:140:31: warning:
comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int64_t i = 0; i != elements; ++i) {
~~^~~~~~~~~~~
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp: In function
'std::vector<std::unique_ptr<turbodbc_arrow::{anonymous}::parameter_converter>
> turbodbc_arrow::{anonymous}::make_converters(const arrow::Table&,
turbodbc::bound_parameter_set&)':
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp:354:75: error:
'using element_type = class arrow::ChunkedArray {aka class
arrow::ChunkedArray}' has no member named 'data'
std::shared_ptr<ChunkedArray> const & data =
table.column(i)->data();
^~~~
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp: In instantiation of
'void
turbodbc_arrow::{anonymous}::string_converter::set_batch_of_type(std::size_t,
std::size_t) [with String = std::__cxx11::basic_string<char>; std::size_t =
long unsigned int]':
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp:173:57: required
from here
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp:121:33: warning:
comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int64_t i = 0; i != elements; ++i) {
~~^~~~~~~~~~~
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp:359:40: warning:
this statement may fall through [-Wimplicit-fallthrough=]
converters.emplace_back(new null_converter(data, parameters,
i));
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../cpp/turbodbc_arrow/Library/src/set_arrow_parameters.cpp:360:15: note: here
case arrow::Type::INT8:
^~~~
{code}
I'll submit a patch to turbodbc that fixes this
> [CI][Crossbow] Nightly turbodbc job fails
> -----------------------------------------
>
> Key: ARROW-6428
> URL: https://issues.apache.org/jira/browse/ARROW-6428
> Project: Apache Arrow
> Issue Type: Bug
> Components: Continuous Integration
> Reporter: Neal Richardson
> Assignee: Wes McKinney
> Priority: Blocker
> Labels: nightly
> Fix For: 0.15.0
>
>
> See https://circleci.com/gh/ursa-labs/crossbow/2313. Either fix, skip job and
> create followup Jira to unskip, or delete job.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)