[ 
https://issues.apache.org/jira/browse/ARROW-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928537#comment-16928537
 ] 

Benjamin Kietzman commented on ARROW-6228:
------------------------------------------

[~pitrou] [~xhochy] Context lines can make the precise indices of array 
disagreements harder to read:

{code}
@@ -3, +3 @@
 2
 3
 4
-5 # do mental math to figure out that this corresponds to element 6 of the base
 6
 7
 8
{code}

Perhaps it would be better to always place the hunk header directly before 
changes

{code}
... # elipsis at zero indent delimits hunks when context lines are present
 2
 3
 4
@@ -6, +6 @@
-5
 6
 7
 8
...
{code}

> [C++] Add context lines to Diff formatting
> ------------------------------------------
>
>                 Key: ARROW-6228
>                 URL: https://issues.apache.org/jira/browse/ARROW-6228
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: C++
>            Reporter: Benjamin Kietzman
>            Assignee: Benjamin Kietzman
>            Priority: Trivial
>
> Diff currently renders only inserted or deleted elements, but context lines 
> can be helpful to viewers of the diff. Add an option for configurable context 
> line count to Diff and EqualOptions



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to