[ 
https://issues.apache.org/jira/browse/ARROW-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neal Richardson resolved ARROW-6337.
------------------------------------
    Fix Version/s: 0.15.0
       Resolution: Fixed

Issue resolved by pull request 5399
[https://github.com/apache/arrow/pull/5399]

> [R] as_tibble in R API is a misnomer
> ------------------------------------
>
>                 Key: ARROW-6337
>                 URL: https://issues.apache.org/jira/browse/ARROW-6337
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: James Lamb
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 0.15.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> As of ARROW-5190, the R package's dependency on *tibble* has been moved from 
> *Imports* to *Suggests*. However, this signature of *read_parquet(), 
> read_delim_arrow(), read_json_arrow(),* and *read_feather()* all still have 
> an argument called "as_tibble".
> Per [this 
> comment|[https://github.com/apache/arrow/pull/4454#issuecomment-500563214],] 
> the argument "as_tibble" is a misnomer. If that argument is given a TRUE, 
> those functions will return a data.frame, not a tibble. I agree with Neal's 
> comment...I think that instead of changing return type based on a boolean, it 
> would be better for all the *read_** functions to return a data.frame and for 
> other types of operations to get their own functions.
> I think it's important to consider this type of user-facing breaking change 
> _now_ while the R package's version is still 0.x.
> As always, thanks for hearing me out!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to