[
https://issues.apache.org/jira/browse/ARROW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Kietzman updated ARROW-6711:
--------------------------------
Description:
There is unnecessary boilerplate required when using the Filter/Expression
classes. Filter is no longer necessary; it (and FilterVector) can be replaced
with Expression. Expression is sufficiently general that it can be subclassed
to provide any custom functionality which would have been added through a
GenericFilter (add some tests for this).
Additionally rows within RecordBatches yielded from a scan are not currently
filtered using Expression::Evaluate(). (Add tests ensuring both row filtering
and pruning obey Kleene logic)
Add some comments on the mechanism of {{Assume()}} too
was:
There is unnecessary boilerplate required when using the Filter/Expression
classes. Filter is no longer necessary; it (and FilterVector) can be replaced
with Expression. Expression is sufficiently general that it can be subclassed
to provide any custom functionality which would have been added through a
GenericFilter (add some tests for this).
Additionally rows within RecordBatches yielded from a scan are not currently
filtered using Expression::Evaluate(). (Add tests ensuring both row filtering
and pruning obey Kleene logic)
> [C++] Consolidate Filter and Expression classes
> -----------------------------------------------
>
> Key: ARROW-6711
> URL: https://issues.apache.org/jira/browse/ARROW-6711
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Ben Kietzman
> Assignee: Ben Kietzman
> Priority: Major
> Labels: dataset
> Fix For: 1.0.0
>
>
> There is unnecessary boilerplate required when using the Filter/Expression
> classes. Filter is no longer necessary; it (and FilterVector) can be replaced
> with Expression. Expression is sufficiently general that it can be subclassed
> to provide any custom functionality which would have been added through a
> GenericFilter (add some tests for this).
> Additionally rows within RecordBatches yielded from a scan are not currently
> filtered using Expression::Evaluate(). (Add tests ensuring both row filtering
> and pruning obey Kleene logic)
> Add some comments on the mechanism of {{Assume()}} too
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
