[
https://issues.apache.org/jira/browse/ARROW-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942124#comment-16942124
]
Omer Ozarslan commented on ARROW-6405:
--------------------------------------
Ah, thanks. Sorry for delay. I was occupied with some other stuff. I also
thought I could delay this to yield CI to more critical bugs before the release.
It sounds okay to me to close this issue with that PR merged. I'm not sure if
it's necessary create a separate PR just for this.
There seems a few other points move is used. You may want to replace those in
the PR as well:
{code:java}
~/src/ext/arrow/python/pyarrow master grep "move" -rnw . | grep -E
".(pyx|pxi|pxd)"
./_flight.pyx:946: move(handler)))
./_flight.pyx:1358: new CPyFlightDataStream(result,
move(data_stream)))
./_flight.pyx:1485: new CPyFlightDataStream(result, move(data_stream)))
./includes/libarrow_flight.pxd:378: unique_ptr[CFlightDataStream]
move(unique_ptr[CFlightDataStream]) nogil
./includes/libarrow_flight.pxd:379: unique_ptr[CServerAuthHandler]
move(unique_ptr[CServerAuthHandler]) nogil
./includes/libarrow_flight.pxd:380: unique_ptr[CClientAuthHandler]
move(unique_ptr[CClientAuthHandler]) nogil
./_fs.pyx:249: def move(self, src, dest):
{code}
cymove doesn't enforce nogil as it made sense to me to leave decision for the
gil to the caller of move (it's just casting after all).
> [Python] Add std::move wrapper for use in Cython
> ------------------------------------------------
>
> Key: ARROW-6405
> URL: https://issues.apache.org/jira/browse/ARROW-6405
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Wes McKinney
> Priority: Major
> Fix For: 1.0.0
>
>
> [~bkietz] pointed out this to me
> https://github.com/ozars/cymove
> This is small enough that we should simply copy this code into our codebase
> (MIT-licensed) and fix the couple of places where we have
> {{std::move}}-related workarounds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
