Ben Kietzman resolved ARROW-6711.
    Resolution: Fixed

Issue resolved by pull request 5594

> [C++] Consolidate Filter and Expression classes
> -----------------------------------------------
>                 Key: ARROW-6711
>                 URL: https://issues.apache.org/jira/browse/ARROW-6711
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Ben Kietzman
>            Assignee: Ben Kietzman
>            Priority: Major
>              Labels: dataset, pull-request-available
>             Fix For: 1.0.0
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
> There is unnecessary boilerplate required when using the Filter/Expression 
> classes. Filter is no longer necessary; it (and FilterVector) can be replaced 
> with Expression. Expression is sufficiently general that it can be subclassed 
> to provide any custom functionality which would have been added through a 
> GenericFilter (add some tests for this).
> Additionally rows within RecordBatches yielded from a scan are not currently 
> filtered using Expression::Evaluate(). (Add tests ensuring both row filtering 
> and pruning obey Kleene logic)
> Add some comments on the mechanism of {{Assume()}} too, and refactor it not 
> to return a Result (its failure modes are covered by {{Validate()}})

This message was sent by Atlassian Jira

Reply via email to