[ 
https://issues.apache.org/jira/browse/ARROW-6772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952850#comment-16952850
 ] 

Ben Kietzman commented on ARROW-6772:
-------------------------------------

Use the `util::EqualityComparable` mixin defined in 
https://github.com/apache/arrow/pull/5621

At the same time it'd be useful to incorporate the `util::ToStringOstreamable` 
mixin (introduced in the same PR)

> [C++] Add operator== for interfaces with an Equals() method
> -----------------------------------------------------------
>
>                 Key: ARROW-6772
>                 URL: https://issues.apache.org/jira/browse/ARROW-6772
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Ben Kietzman
>            Assignee: Ben Kietzman
>            Priority: Major
>
> A common pattern in tests is {{ASSERT_TRUE(schm->Equals(*other)}}. The 
> addition of overloaded equality operators will allow this o be written 
> {{ASSERT_EQ(*schm, *other)}}, which is more idiomatic GTEST usage and will 
> allow more informative assertion failure messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to