[ https://issues.apache.org/jira/browse/ARROW-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958951#comment-16958951 ]
Ben Kietzman commented on ARROW-6299: ------------------------------------- In the case of CSV, it's most natural to consider files with a comma separator and files with a tab separator as different formats. > [C++] Simplify FileFormat classes to singletons > ----------------------------------------------- > > Key: ARROW-6299 > URL: https://issues.apache.org/jira/browse/ARROW-6299 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ > Reporter: Ben Kietzman > Assignee: Ben Kietzman > Priority: Minor > Labels: dataset > Fix For: 1.0.0 > > > ParquetFileFormat has no state, so passing it around by > shared_ptr<FileFormat> is not necessary; we could just keep a single static > instance and pass raw pointers. > [~wesmckinn] is there a case where a FileFormat might have state? -- This message was sent by Atlassian Jira (v8.3.4#803005)