[
https://issues.apache.org/jira/browse/ARROW-7289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Takashi Hashida updated ARROW-7289:
-----------------------------------
Description:
[https://github.com/apache/arrow/blob/master/csharp/src/Apache.Arrow/Types/ListType.cs#L28]
The ListType constructor has two arguments but 'ValueDataType' can be
determined by 'Filed.DataType' and 'ValueFiled' can be created by valueDataType.
It seems to me that the constructor should be separated to "ListType(Field
valueField)" and " ListType(IArrowType valueDataType)".
was:
[https://github.com/apache/arrow/blob/master/csharp/src/Apache.Arrow/Types/ListType.cs#L28]
The ListType constructor has two arguments but 'ValueDataType' can be
determined by 'Filed.DataType' and 'ValueFiled' can be created by valueDataType.
It seems to me that the constructor should be separated to "ListType(Field
valueField)" and " ListType(Field valueField)"
> [C#] ListType constructor argument is redundant
> -----------------------------------------------
>
> Key: ARROW-7289
> URL: https://issues.apache.org/jira/browse/ARROW-7289
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C#
> Affects Versions: 0.15.1
> Reporter: Takashi Hashida
> Priority: Major
>
> [https://github.com/apache/arrow/blob/master/csharp/src/Apache.Arrow/Types/ListType.cs#L28]
>
> The ListType constructor has two arguments but 'ValueDataType' can be
> determined by 'Filed.DataType' and 'ValueFiled' can be created by
> valueDataType.
> It seems to me that the constructor should be separated to "ListType(Field
> valueField)" and " ListType(IArrowType valueDataType)".
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
