[ 
https://issues.apache.org/jira/browse/ARROW-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992628#comment-16992628
 ] 

Wes McKinney commented on ARROW-7362:
-------------------------------------

I can't remember what was the argument before (maybe I was making it, sorry), 
but I think it would be OK for {{flatten()}} to return the sliced values, while 
{{.values}} does need to return the unsliced values I think. As long as an 
appropriate caveat is added to the docstring to say that the offsets should not 
be used (for random access purposes) with the result of {{flatten()}}

> [Python] ListArray.flatten() should take care of slicing offsets
> ----------------------------------------------------------------
>
>                 Key: ARROW-7362
>                 URL: https://issues.apache.org/jira/browse/ARROW-7362
>             Project: Apache Arrow
>          Issue Type: Bug
>            Reporter: Zhuo Peng
>            Assignee: Zhuo Peng
>            Priority: Minor
>
> Currently ListArray.flatten() simply returns the child array. If a ListArray 
> is a slice of another ListArray, they will share the same child array, 
> however the expected behavior (I think) of flatten() should be returning an 
> Array that's a concatenation of all the sub-lists in the ListArray, so the 
> slicing offset should be taken into account.
>  
> For example:
> a = pa.array([[1], [2], [3]])
> assert a.flatten().equals(pa.array([1,2,3]))
> # expected:
> a.slice(1).flatten().equals(pa.array([2, 3]))



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to