[ 
https://issues.apache.org/jira/browse/ARROW-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993670#comment-16993670
 ] 

Francois Saint-Jacques commented on ARROW-7373:
-----------------------------------------------

Be careful by passing a RandomAccessFile, they require materializing a file 
descriptor, path don't.

> [C++][Dataset] Remove FileSource
> --------------------------------
>
>                 Key: ARROW-7373
>                 URL: https://issues.apache.org/jira/browse/ARROW-7373
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++ - Dataset
>    Affects Versions: 0.15.1
>            Reporter: Ben Kietzman
>            Assignee: Ben Kietzman
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> FileSource doesn't do enough, and should be removed. Methods in 
> {{FileFormat}} etc which reference the class should be refactored to take a 
> {{RandomAccessFile}} and convenience overloads provided to take a buffer or a 
> (path, filesystem).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to