[ 
https://issues.apache.org/jira/browse/ARROW-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019636#comment-17019636
 ] 

Ben Kietzman commented on ARROW-6929:
-------------------------------------

[[email protected]] The "first offset == 0" requirement *was* explicitly 
stated in Layout.rst, line 286. It was removed in 
https://github.com/apache/arrow/commit/67d46c7149115ea1ab094ab80f1e1ff4add48be9 
but that may not have been intentional,  [~wesm]? I agree that requirement 
seems unnecessary and could be safely removed now.

I believe the other two points have been resolved: validate no longer checks 
for empty lists "under" null bits and I don't observe incorrect logic in the 
case of ValidateListArray(trucated).

> [C++] ValidateArray is out of sync with the ListArray IPC specification
> -----------------------------------------------------------------------
>
>                 Key: ARROW-6929
>                 URL: https://issues.apache.org/jira/browse/ARROW-6929
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Micah Kornfield
>            Assignee: Ben Kietzman
>            Priority: Major
>             Fix For: 0.16.0
>
>
> * It appears to check that null values take zero space
>  * It still checks for a begin offset of 0 if the array isn't sliced 
> (technically this doesn't seem necessary and it could be non-zero even if the 
> array wasn't sliced.)
>  * I think it also fails if an array is sliced to truncate it since it should 
> compare length to data_extent instead of last_offset.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to