[
https://issues.apache.org/jira/browse/ARROW-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Micah Kornfield resolved ARROW-6871.
------------------------------------
Fix Version/s: 1.0.0
Resolution: Fixed
Issue resolved by pull request 5645
[https://github.com/apache/arrow/pull/5645]
> [Java] Enhance TransferPair related parameters check and tests
> --------------------------------------------------------------
>
> Key: ARROW-6871
> URL: https://issues.apache.org/jira/browse/ARROW-6871
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java
> Reporter: Ji Liu
> Assignee: Ji Liu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> {{TransferPair}} related param checks in different classes have potential
> problems:
> i. {{copyValueSafe}} do not check from index, if from > valueCount, no error
> is shown.
> ii. {{splitAndTansfer}} has no indices check in classes like {{VarcharVector}}
> iii. {{splitAndTranser}} indices check in classes like UnionVector is not
> correct (Preconditions.checkArgument(startIndex + length <= valueCount)),
> should check params separately.
> iv. some assert usages should be replaced with {{Preconditions}}.
> v. should add more UT to cover corner cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)