Tomasz Cheda created ARROW-8032:
-----------------------------------

             Summary: CPP example parquet-arrow project includes broken 
FindParquet.cmake
                 Key: ARROW-8032
                 URL: https://issues.apache.org/jira/browse/ARROW-8032
             Project: Apache Arrow
          Issue Type: Bug
          Components: C++
    Affects Versions: 1.0.0
         Environment: NA
            Reporter: Tomasz Cheda


The example project at 
[https://github.com/apache/arrow/tree/master/cpp/examples/parquet/parquet-arrow/cmake_modules]
 includes a broken version of FindParquet.cmake ( 
[https://github.com/apache/arrow/blob/master/cpp/examples/parquet/parquet-arrow/cmake_modules/FindParquet.cmake]
 )

The other module is, correctly, a link to FindArrow.cmake in 
[https://github.com/apache/arrow/tree/master/cpp/cmake_modules]

For the curious, the broken part is assuming that FindPkgConfig variables will 
be set if the module is found - this can be false if the include directory is 
/usr/include. This can be controlled by one of FindPkgConfig's config 
variables, but the default behaviour changes as of CMake 3.10. It then 
erroneously reports that Parquet has not been found.

This is not a major bug, but I based my build files off of those in the example 
directory and it took me a LONG time to figure out the error. It can be really 
confusing for new users and is simple to fix.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to