[
https://issues.apache.org/jira/browse/ARROW-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091739#comment-17091739
]
Mark Hildreth edited comment on ARROW-8559 at 4/24/20, 5:00 PM:
----------------------------------------------------------------
Generally in favor, but one question and one bikeshed:
Question: perhaps my Rust-fu is lacking, but why would we also need a
{{SendableBatchIterator}}? If we want to make sure that a type marks itself
{{Send}} and/or {{Sync}}, it can do that. If an interface wants to accept only
{{Send}} and/or {{Sync}} iterators, it could do {{BatchIterator + Send + Sync}}.
Bikeshed: There are no {{std::iter::Iterator}} trait implementation for either
{{BatchIterator}} or {{RecordBatchReader}}. Thus, using the name {{Iterator}}
seems a bit misleading.
was (Author: markhildreth):
Generally in favor, but one question and one bikeshed:
Question: perhaps my Rust-fu is lacking, but why would we need a
{{SendableBatchIterator}}? If we want to make sure that a type marks itself
{{Send}} and/or {{Sync}}, it can do that. If an interface wants to accept only
{{Send}} and/or {{Sync}} iterators, it could do {{BatchIterator + Send + Sync}}.
Bikeshed: There are no {{std::iter::Iterator}} trait implementation for either
{{BatchIterator}} or {{RecordBatchReader}}. Thus, using the name {{Iterator}}
seems a bit misleading.
> [Rust] Consolidate Record Batch iterator traits in main arrow crate
> -------------------------------------------------------------------
>
> Key: ARROW-8559
> URL: https://issues.apache.org/jira/browse/ARROW-8559
> Project: Apache Arrow
> Issue Type: New Feature
> Components: Rust
> Reporter: Paddy Horan
> Assignee: Paddy Horan
> Priority: Major
>
> We have the `BatchIterator` trait in DataFusion and the `RecordBatchReader`
> trait in the main arrow crate.
> They differ in that `BatchIterator` is Send + Sync. They should both be in
> the Arrow crate and be named `BatchIterator` and `SendableBatchIterator`
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
