[
https://issues.apache.org/jira/browse/ARROW-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093616#comment-17093616
]
Phil Price edited comment on ARROW-8394 at 4/27/20, 3:15 PM:
-------------------------------------------------------------
This also happens with `0.17.0` from what I can tell there are two things which
I would consider adoption blockers:
# apache-arrow compiles with [email protected], but [email protected]+ has stricter
type-checks, and cannot consume the output. A couple of cases I've found that
are invalid:
## Extension of static `new()` methods with different typed parameter order
(column<T> derived from chunked<T> but changes the signature of `new` to takes
`string | Field` as the first param over `Data`
## Not passing template types to fields (e.g. `foo: Schema` to `foo:
Schema<T>`)
# Attempting to upgrade `apache-arrow` to [email protected] (or 3.9-beta) falls
afoul of a typescript compiler bug
([https://github.com/microsoft/TypeScript/issues/35186]); from my
understanding, the compiler is on an error path anyway but bails when trying to
print error detail. This makes the upgrade difficult as it's a case of
whack-a-mole.
was (Author: pprice):
This also happens with `0.17.0` from what I can tell there are two things which
I would consider adoption blockers:
# `apache-arrow` compiles with [email protected], but [email protected]+ has
stricter type-checks, and cannot consume the output. A couple of cases I've
found that are invalid:
## Extension of static `new()` methods with different typed parameter order
(column<T> derived from chunked<T> but changes the signature of `new` to takes
`string | Field` as the first param over `Data`
## Not passing template types to fields (e.g. `foo: Schema` to `foo:
Schema<T>`)
# Attempting to upgrade `apache-arrow` to [email protected] (or 3.9-beta) falls
afoul of a typescript compiler bug
([https://github.com/microsoft/TypeScript/issues/35186]); from my
understanding, the compiler is on an error path anyway but bails when trying to
print error detail. This makes the upgrade difficult as it's a case of
whack-a-mole.
> Typescript compiler errors for arrow d.ts files, when using es2015-esm package
> ------------------------------------------------------------------------------
>
> Key: ARROW-8394
> URL: https://issues.apache.org/jira/browse/ARROW-8394
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Affects Versions: 0.16.0
> Reporter: Shyamal Shukla
> Priority: Blocker
>
> Attempting to use apache-arrow within a web application, but typescript
> compiler throws the following errors in some of arrow's .d.ts files
> import \{ Table } from "../node_modules/@apache-arrow/es2015-esm/Arrow";
> export class SomeClass {
> .
> .
> constructor() {
> const t = Table.from('');
> }
> *node_modules/@apache-arrow/es2015-esm/column.d.ts:14:22* - error TS2417:
> Class static side 'typeof Column' incorrectly extends base class static side
> 'typeof Chunked'. Types of property 'new' are incompatible.
> *node_modules/@apache-arrow/es2015-esm/ipc/reader.d.ts:238:5* - error TS2717:
> Subsequent property declarations must have the same type. Property 'schema'
> must be of type 'Schema', but here has type 'Schema'.
> 238 schema: Schema;
> *node_modules/@apache-arrow/es2015-esm/recordbatch.d.ts:17:18* - error
> TS2430: Interface 'RecordBatch' incorrectly extends interface 'StructVector'.
> The types of 'slice(...).clone' are incompatible between these types.
> the tsconfig.json file looks like
> {
> "compilerOptions": {
> "target":"ES6",
> "outDir": "dist",
> "baseUrl": "src/"
> },
> "exclude": ["dist"],
> "include": ["src/*.ts"]
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
