[ 
https://issues.apache.org/jira/browse/ARROW-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109886#comment-17109886
 ] 

Yibo Cai commented on ARROW-8762:
---------------------------------

Gandiva BitmapAnd code[1] leverages the fact that gandiva bitmap buffer are 
always 64-bit aligned in size[2]. BitmapAnd in bit_util.cc is a general 
implementation.
Maybe we should just leave gandiva code as is.

[1] 
https://github.com/apache/arrow/blob/e5a33f1220705aec6a224b55d2a6f47fbd957603/cpp/src/gandiva/bitmap_accumulator.cc#L38
[2] 
https://github.com/apache/arrow/blob/e5a33f1220705aec6a224b55d2a6f47fbd957603/cpp/src/gandiva/local_bitmaps_holder.h#L68

> [C++][Gandiva] Replace Gandiva's BitmapAnd with common implementation
> ---------------------------------------------------------------------
>
>                 Key: ARROW-8762
>                 URL: https://issues.apache.org/jira/browse/ARROW-8762
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++, C++ - Gandiva
>            Reporter: Wes McKinney
>            Priority: Major
>             Fix For: 1.0.0
>
>
> Now that the arrow/util/bit_util.h implementation has been optimized, we 
> should just use that one



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to