[ 
https://issues.apache.org/jira/browse/ARROW-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125040#comment-17125040
 ] 

Simon Watts commented on ARROW-5300:
------------------------------------

BTW - you need to declare {{ARROW_MEMORY_POOL_DEFAULT}} to be empty; the OP 
will set it to value 1.  So pass {{-DARROW_MEMORY_POOL_DEFAULT=""}} instead.

However this has a secondary effect in now creating default constructors, which 
were previously satisfied by constructors which take a {{MemoryPool*}} with the 
defaulted value.

This is _very_ difficult to work around in pre-processing if you only have 
{{ARROW_MEMORY_POOL_DEFAULT}} to use, as you would need to check whether this 
expanded to empty.  There may be some boost-magic to do this, but for our use 
case it was easier to define something which could be used with {{#if}} instead.

> [C++] 0.13 FAILED to build with option -DARROW_NO_DEFAULT_MEMORY_POOL
> ---------------------------------------------------------------------
>
>                 Key: ARROW-5300
>                 URL: https://issues.apache.org/jira/browse/ARROW-5300
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>    Affects Versions: 0.13.0
>            Reporter: Weihua Jiang
>            Assignee: Francois Saint-Jacques
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.15.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I tried to upgrade Apache Arrow to 0.13. But, when building Apache Arrow 0.13 
> with option {{-DARROW_NO_DEFAULT_MEMORY_POOL}}, I got a lot of failures.
> It seems 0.13 assuming default memory pool always available.
>  
> My cmake command is:
> |{{make .. -DCMAKE_BUILD_TYPE=Release -DARROW_BUILD_TESTS=off 
> -DARROW_USE_GLOG=off -DARROW_WITH_LZ4=off -DARROW_WITH_ZSTD=off 
> -DARROW_WITH_SNAPPY=off -DARROW_WITH_BROTLI=off -DARROW_WITH_ZLIB=off 
> -DARROW_JEMALLOC=off -DARROW_CXXFLAGS=-DARROW_NO_DEFAULT_MEMORY_POOL}}|
> I tried to fix the compilation by adding some missing constructors. However, 
> it seems this issue is bigger than I expected. It seems all the builders and 
> appenders have this issue as many classes even don't have a memory pool 
> associated. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to