[ 
https://issues.apache.org/jira/browse/ARROW-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125193#comment-17125193
 ] 

Jacek Pliszka commented on ARROW-9022:
--------------------------------------

I believe we should keep it identical. User can always promote/cast explicitly.

 

I am for Antoine's approach from mail thread - user selectable option - either 
error on overflow or ignore it.

> [C++][Compute] Make Add function safe for numeric limits
> --------------------------------------------------------
>
>                 Key: ARROW-9022
>                 URL: https://issues.apache.org/jira/browse/ARROW-9022
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Krisztian Szucs
>            Assignee: Krisztian Szucs
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0.0
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Currently the output type of the Add function is identical with the argument 
> types which makes it unsafe to add numeric limit values, so instead of using 
> {{(int8, int8) -> int8}} signature we should use {{((int8, int8) -> int16}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to