[
https://issues.apache.org/jira/browse/ARROW-8974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antoine Pitrou resolved ARROW-8974.
-----------------------------------
Fix Version/s: 1.0.0
Resolution: Fixed
Issue resolved by pull request 7373
[https://github.com/apache/arrow/pull/7373]
> [C++] Refine TransferBitmap template parameters
> -----------------------------------------------
>
> Key: ARROW-8974
> URL: https://issues.apache.org/jira/browse/ARROW-8974
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Yibo Cai
> Assignee: Yibo Cai
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> [TransferBitmap|https://github.com/apache/arrow/blob/44e723d9ac7c64739d419ad66618d2d56003d1b7/cpp/src/arrow/util/bit_util.cc#L110]
> has two template parameters of bool type with four combinations.
> Change them to function parameters can reduce code size. I think
> "restore_trailing_bits" cannot impact performance. "invert_bits" needs
> benchmark.
> Also, bool parameter is hard to figure out at [caller
> side|https://github.com/apache/arrow/blob/44e723d9ac7c64739d419ad66618d2d56003d1b7/cpp/src/arrow/util/bit_util.cc#L208],
> better to use meaningful defines.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
