Ben Kietzman created ARROW-9492:
-----------------------------------

             Summary: [C++] Ensure private functions are static or in an 
anonymous namespace
                 Key: ARROW-9492
                 URL: https://issues.apache.org/jira/browse/ARROW-9492
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
    Affects Versions: 0.17.1
            Reporter: Ben Kietzman


There are a number of functions which are not intended to be exported (for 
example, they are defined in a {{.cc}} file) but are not marked {{static 
inline}} or declared in an anoymous namespace. This can lead to surprising link 
errors. Existing private functions should be marked appropriately, and ideally 
a linter could be assembled to ensure new ones are not added without 
appropriate markings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to