Ian Cook created ARROW-12696:
--------------------------------
Summary: [R] Improve testing of error messages converted to
warnings
Key: ARROW-12696
URL: https://issues.apache.org/jira/browse/ARROW-12696
Project: Apache Arrow
Issue Type: Improvement
Components: R
Affects Versions: 4.0.0
Reporter: Ian Cook
Assignee: Ian Cook
The {{abandon_ship()}} function catches errors that occur because of
unsupported functions/arguments and issues warnings in place of the of errors.
These warnings do not use the same messages as the errors.
There are many dplyr tests that use {{expect_warning()}} to effectively check
for that an error occurred before it was converted to a warning. These tests do
not assert the expected error message, because that message is lost in the
conversion to a warning.
Consider ways to improve these tests to enable them to assert the expected
error messages.
Alternatively, consider:
* Whether we intend to keep {{abandon_ship()}} working as it does even after
dplyr support in the package becomes more comprehensive
* Whether we should modify {{abandon_ship()}} to incorporate the original
error message into the warning it gives instead of throwing a generic and
likely less helpful warning message
See the related discussion at
[https://github.com/apache/arrow/pull/10190/files#r628314240]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
