pitrou commented on PR #10: URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1203176462
> Also, keep in mind that in C, unlike C++, it takes more work to guarantee that functions will actually be inlined in all compilers. But it's also most of the time pointless. The compiler is usually able to reason on code performance better than the developer, except in fringe cases. I would be in favor of inline functions over macros, which have a non-trivial debugging and maintainability cost. For the record, CPython has started migrating from macros over to inline functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
