paleolimbot commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r939043459
##########
src/nanoarrow/buffer_inline.h:
##########
@@ -15,14 +15,20 @@
// specific language governing permissions and limitations
// under the License.
+#ifndef NANOARROW_BUFFER_INLINE_H_INCLUDED
+#define NANOARROW_BUFFER_INLINE_H_INCLUDED
+
#include <errno.h>
-#include <stddef.h>
-#include <stdlib.h>
+#include <stdint.h>
#include <string.h>
-#include "nanoarrow.h"
+#include "typedefs_inline.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
-static int64_t ArrowGrowByFactor(int64_t current_capacity, int64_t
new_capacity) {
+static inline int64_t _ArrowGrowByFactor(int64_t current_capacity, int64_t
new_capacity) {
Review Comment:
I see...I was copying the pattern used by headers generated by nanopb
("private" inline functions). Is there a better pattern for functions that have
to be visible for inline functions but that shouldn't be accessed otherwise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
