lidavidm commented on issue #55: URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1212119635
> Is the idea that `RowCount` would do double duty as the number of rows in a result set OR the number of rows affected by an update/insert? Yeah, I don't see a reason to have two separate methods. > > Given the lack of reliable support, i'm fine with leaving the LastInsertedID out for now. Also, I would argue these sorts of use cases are mostly out of scope, though that's mostly my assumption. > > > Returning strings from a C API is a bit annoying.... > > Yea... I personally prefer the ODBC-style of passing a caller allocated buffer and length. But this works best when the caller can have a semblance or idea of how big of a buffer to allocate in the first place, so we'd have to either come up with a standard or some function to retrieve expected lengths of particular attributes so the caller can know how much to allocate, it might be simpler to go with the `AdbcBlob` approach you have here? It's also a little more consistent with AdbcError and the C Data Interface. But yeah, I don't think either is clearly better than the other? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
