krlmlr commented on issue #61: URL: https://github.com/apache/arrow-adbc/issues/61#issuecomment-1214402390
Just to be sure we're on the same page: - a "query" is a single SQL string that can return a result set but doesn't have to - a "statement" is the result of preparing an SQL string with placeholders, so that parameters can be added - we're debating whether the caller should declare up front if a result is expected In R DBI we're using the term "query" to indicate something that returns a result set (with or without parameters), and a "statement" doesn't return a result set but we can query the number of rows affected. The more information we can share with the driver up front, the better. Do we really need two methods, though -- would a single `Query(struct AdbcConnection*, const char*, struct ArrowArrayStream*, struct AdbcError*)` with an optional third argument (can be `NULL`) also work? Or perhaps an option argument that indicates if we expect a result set, and return metadata (rows affected etc.) via the arrow stream? What should happen to queries that indicate that no result set is expected but where a result set is available? Is a warning useful or annoying? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
