lidavidm opened a new issue, #68: URL: https://github.com/apache/arrow-adbc/issues/68
We should improve the documentation/justification for this interface, describe better what happens when it's not supported, and make sure it lines up with what potential users of the interface expect. In particular, it should line up with Spark's DataSourceV2. Looking at [ReadSupport](https://spark.apache.org/docs/2.4.0/api/java/index.html?org/apache/spark/sql/sources/v2/ReadSupport.html), the main thing is that we need to return the schema and partitions at the same time. So we might want to return something like this: ``` struct AdbcPartitions { struct ArrowSchema result_schema; size_t num_partitions; uint8_t** partitions; void* private_data; }; AdbcStatusCode AdbcPartitionsRelease(struct AdbcPartitions*, struct AdbcError*); ``` Also see #61 which proposes refactoring the Execute API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
