kou opened a new issue, #15256: URL: https://github.com/apache/arrow/issues/15256
### Describe the bug, including details regarding any error messages, version, and platform. Because `arrow::dataset::DefaultPartitioning::Format()` isn't implemented: https://github.com/apache/arrow/blob/2acc51a7d5304c3fc6a432f1c09946547ca91d74/cpp/src/arrow/dataset/partition.cc#L92-L95 It's required in `WriteBatch()`: https://github.com/apache/arrow/blob/2acc51a7d5304c3fc6a432f1c09946547ca91d74/cpp/src/arrow/dataset/file_base.cc#L380-L381 Is it expected that we can't use `arrow::dataset::Partitioning::Default()` for writing dataset? If it's expected, how about removing `arrow::dataset::Partitioning::Default()` because it's useless? If it's not expected, how about implementing `arrow::dataset::DefaultPartitioning::Format()` like the following? ```diff diff --git a/cpp/src/arrow/dataset/partition.cc b/cpp/src/arrow/dataset/partition.cc index 46cdf9023c..13add35fb8 100644 --- a/cpp/src/arrow/dataset/partition.cc +++ b/cpp/src/arrow/dataset/partition.cc @@ -90,8 +90,7 @@ std::shared_ptr<Partitioning> Partitioning::Default() { } Result<PartitionPathFormat> Format(const compute::Expression& expr) const override { - return Status::NotImplemented("formatting paths from ", type_name(), - " Partitioning"); + return PartitionPathFormat{"", ""}; } Result<PartitionedBatches> Partition( ``` ### Component(s) C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
