jorisvandenbossche opened a new issue, #35817:
URL: https://github.com/apache/arrow/issues/35817

   The "value_counts" kernel indicates that nulls in the input are skipped:
   
   
https://github.com/apache/arrow/blob/431785f3062199b2b9052902b67492b933744833/cpp/src/arrow/compute/kernels/vector_hash.cc#L748-L753
   
   But that's not actually the case. Nulls are also counted and included in the 
output:
   
   ```python
   In [1]: import pyarrow.compute as pc
   
   In [2]: pc.value_counts([1, 2, 2, None, None])
   Out[2]: 
   <pyarrow.lib.StructArray object at 0x7fb88e1c6f20>
   -- is_valid: all not null
   -- child 0 type: int64
     [
       1,
       2,
       null
     ]
   -- child 1 type: int64
     [
       1,
       2,
       2
     ]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to