h-vetinari opened a new issue, #36594: URL: https://github.com/apache/arrow/issues/36594
### Describe the bug, including details regarding any error messages, version, and platform. The following logic is deficient: https://github.com/apache/arrow/blob/05620b186f2d27fd9d28dab010c2fa58e67c0ce7/cpp/src/gandiva/precompiled/CMakeLists.txt#L33-L47 It will never reach the `elseif` or the `else` (as it just decides between <=1930 yes or no), and will pass an empty `FMS_COMPATIBILITY` for VS2022. Also worth noting, [elsewhere](https://github.com/apache/arrow/blob/05620b186f2d27fd9d28dab010c2fa58e67c0ce7/cpp/cmake_modules/SetupCxxFlags.cmake#L171-L173) `MSVC_VERSION` uses 19, and not 19xx. This is also wrong according to the CMake [docs](https://cmake.org/cmake/help/latest/variable/MSVC_VERSION.html). ### Component(s) C++ - Gandiva -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
