scottlepp opened a new issue, #969:
URL: https://github.com/apache/arrow-adbc/issues/969

   Tested the driver hitting [this container 
](https://github.com/voltrondata/flight-sql-server-example#option-1---running-from-the-published-docker-image).
   
   ```
   select * from customer
   ```
   
   The customer table has a decimal field, which isn't handled yet by the 
driver, but there is no indication of a failure.  rows.Next just returns false. 
 I've worked around it [here by returning a 
float](https://github.com/scottlepp/arrow-adbc/blob/8f1556f2a4ea77a23825c28f384f472e20045a53/go/adbc/sqldriver/driver.go#L643).
  
   
   Seems it would be better to just log a warning and return nil for that 
column, instead of not returning anything at all.
   
   Not sure the direction on handling decimals, but I see other drivers using 
Arrow return floats:
   
[Snowflake](https://github.com/snowflakedb/gosnowflake/blob/ad2d6fef32718c982faec3ae99a83dc297b1c8ab/converter.go#L387)
   
[Databricks](https://github.com/databricks/databricks-sql-go/blob/65bde57ffd0c127c05fac6988b7d990a98da6f4b/internal/rows/arrowbased/columnValues.go#L460)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to