Light-City opened a new issue, #38624:
URL: https://github.com/apache/arrow/issues/38624

   ### Describe the bug, including details regarding any error messages, 
version, and platform.
   
   The default array options now have a nan comparison of false, but in a unit 
test situation we might expect nan=true.
   for example:
   
   ```
     auto schema = ::arrow::schema({
         {field("a", float32())},
         {field("b", float64())},
     });
   
     std::vector<std::string> expected = {R"([{"a": 1,    "b": 5},
                                              {"a": 1,    "b": 3},
                                              {"a": 3,    "b": null},
                                              {"a": NaN,  "b": 5},
                                              {"a": NaN,  "b": NaN},
                                              {"a": NaN,   "b": null},
                                              {"a": null, "b": 5},
                                              {"a": null, "b": null}
                                             ])"};
     std::vector<std::string> actual = {R"([{"a": 1,    "b": 5},
                                            {"a": 1,    "b": 3},
                                            {"a": 3,    "b": null},
                                            {"a": NaN,  "b": 5},
                                            {"a": NaN,  "b": NaN},
                                            {"a": NaN,   "b": null},
                                            {"a": null, "b": 5},
                                            {"a": null, "b": null}
                                           ])"};
     ASSERT_TABLES_EQUAL(*TableFromJSON(schema, expected), 
*TableFromJSON(schema, actual));
   ```
   
   Now the test will fail.
   
   The reasons were found to be as follows:
   
   ```
     bool Equals(const Array& arr, const EqualOptions& = 
EqualOptions::Defaults()) const;
     bool Equals(const std::shared_ptr<Array>& arr,
                 const EqualOptions& = EqualOptions::Defaults()) const;
   ```
   
   So how can I modify the interface to support this function?
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to