ryan-syed opened a new issue, #1314:
URL: https://github.com/apache/arrow-adbc/issues/1314
The spec doesn't seem clear for case-sensitivity.
Similarly, in the `getObjectsDbSchemas` driver implementation it uses `LIKE`
whereas `getObjectsTables` uses `ILIKE`. What should be the correct handling as
per the spec? Should we allow the patterns to be case-insensitive?
```
func (c *cnxn) getObjectsDbSchemas(ctx context.Context, depth
adbc.ObjectDepth, catalog *string, dbSchema *string) (result
map[string][]string, err error) {
if depth == adbc.ObjectDepthCatalogs {
return
}
conditions := make([]string, 0)
if catalog != nil && *catalog != "" {
conditions = append(conditions, ` CATALOG_NAME LIKE
\'`+*catalog+`\'`)
}
if dbSchema != nil && *dbSchema != "" {
conditions = append(conditions, ` SCHEMA_NAME LIKE
\'`+*dbSchema+`\'`)
}
cond := strings.Join(conditions, " AND ")
if cond != "" {
cond = `statement := 'SELECT * FROM (' || statement || ') WHERE
` + cond + `';`
}
```
```
func (c *cnxn) getObjectsTables(ctx context.Context, depth adbc.ObjectDepth,
catalog *string, dbSchema *string, tableName *string, columnName *string,
tableType []string) (result internal.SchemaToTableInfo, err error) {
if depth == adbc.ObjectDepthCatalogs || depth ==
adbc.ObjectDepthDBSchemas {
return
}
result = make(internal.SchemaToTableInfo)
includeSchema := depth == adbc.ObjectDepthAll || depth ==
adbc.ObjectDepthColumns
conditions := make([]string, 0)
if catalog != nil && *catalog != "" {
conditions = append(conditions, ` TABLE_CATALOG ILIKE
\'`+*catalog+`\'`)
}
if dbSchema != nil && *dbSchema != "" {
conditions = append(conditions, ` TABLE_SCHEMA ILIKE
\'`+*dbSchema+`\'`)
}
if tableName != nil && *tableName != "" {
conditions = append(conditions, ` TABLE_NAME ILIKE
\'`+*tableName+`\'`)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
