westonpace opened a new issue, #41141:
URL: https://github.com/apache/arrow/issues/41141

   ### Describe the enhancement requested
   
   Comment from review of https://github.com/apache/arrow/pull/40696
   
   > nit: a function to create this Status taking arguments like "integer 
literal" and "UInt64Value" would reduce the string literal bloat in the binary 
because "Failed to unpack user defined " wouldn't have to be inlined so many 
times in the literals.
   
   > Adding ARROW_PREDICT_FALSE to the condition would also reduce the inlining 
of code in the block because it becomes cold code code for the compiler.
   
   These changes could be done throughout the file to improve the performance 
of the Substrait serde.
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to