paleolimbot opened a new issue, #884:
URL: https://github.com/apache/arrow-nanoarrow/issues/884

   From the CRAN warnings:
   
   ```
   g++-16 -std=gnu++17 
-I"/home/hornik/tmp/R.check/r-devel-gcc/Work/build/include" -DNDEBUG -I../src/c 
-I../src/c/include -I../src/c/vendor/ 
-I../src/c/vendor/portable-snippets/include/ -I../src/c/vendor/fmt/include 
-I/usr/include/postgresql  -DADBC_EXPORT="" -DFMT_HEADER_ONLY=1  
-I/usr/local/include -D_FORTIFY_SOURCE=3   -fpic  -g -O2 -Wall -pedantic 
-mtune=native   -c c/driver/postgresql/statement.cc -o 
c/driver/postgresql/statement.o
   gcc-16 -I"/home/hornik/tmp/R.check/r-devel-gcc/Work/build/include" -DNDEBUG 
-I../src/c -I../src/c/include -I../src/c/vendor/ 
-I../src/c/vendor/portable-snippets/include/ -I../src/c/vendor/fmt/include 
-I/usr/include/postgresql  -DADBC_EXPORT="" -DFMT_HEADER_ONLY=1  
-I/usr/local/include -D_FORTIFY_SOURCE=3   -fpic  -g -O2 -Wall 
-Wstrict-prototypes -pedantic -mtune=native  -c c/vendor/nanoarrow/nanoarrow.c 
-o c/vendor/nanoarrow/nanoarrow.o
   In file included from /usr/include/stdio.h:970,
                    from c/vendor/nanoarrow/nanoarrow.c:21:
   In function ‘snprintf’,
       inlined from ‘PrivateArrowSchemaToString’ at 
c/vendor/nanoarrow/nanoarrow.c:2056:20:
   /usr/include/x86_64-linux-gnu/bits/stdio2.h:68:10: warning: null destination 
pointer [-Wformat-truncation=]
      68 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      69 |                                    __glibc_objsize (__s), __fmt,
         |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      70 |                                    __va_arg_pack ());
         |                                    ~~~~~~~~~~~~~~~~~
   ```
   
   I think the issue is that `ArrowSchemaToString()` can return `nullptr`, and 
is sometimes used in a printf string. I think this functionally doesn't happen 
because the `ArrowType` in question is provided by an `ArrowSchemaView`, whose 
initializer never assigns an unknown type; however, we should still fix this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to