Mandukhai-Alimaa opened a new issue, #4640:
URL: https://github.com/apache/arrow-adbc/issues/4640

   ### What feature or improvement would you like to see?
   
   The spec doesn't say what should happen to an in-progress transaction when 
`AdbcConnectionRelease` is called before 
`AdbcConnectionCommit/AdbcConnectionRollback`.
   
   Currently, most drivers do not explicitly handle the active transaction 
before closing the connection and rely on the backend behavior. For example: 
postgresql driver just calls 
[`database_->Disconnect`](https://github.com/apache/arrow-adbc/blob/main/c/driver/postgresql/connection.cc#L1152)
 without explicit rollback or commit and Postgresql server aborts the open 
transaction as part of its own session-teardown path when it sees the client 
disconnect. 
   
   Rolling back on close seems like the reasonable default, but this should be 
documented explicitly in the spec rather than left to each driver to infer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to