ennuite opened a new issue, #1267:
URL: https://github.com/apache/arrow-go/issues/1267

   ### Describe the enhancement requested
   
   Add client-side test coverage for Substrait prepared statements in 
`arrow/flight/flightsql/client_test.go`.
   
   PR #732 added server-side coverage for `CreatePreparedSubstraitPlan`, but 
the [review 
discussion](https://github.com/apache/arrow-go/pull/732#discussion_r3733066313) 
identified that the corresponding client path has no dedicated tests.
   
   The tests should cover:
   
   - `Client.PrepareSubstrait` constructing a `CreatePreparedSubstraitPlan` 
action with the supplied plan bytes and Substrait version.
   - Parsing the returned prepared-statement handle and schemas.
   - Preserving all three `is_update` states: absent, `false`, and `true`.
   - `Txn.PrepareSubstrait` request construction, including the transaction ID, 
if it is not already covered through shared helpers.
   
   Query and update execution do not need duplicate coverage here: after 
prepared-statement creation, Substrait and SQL use the same Flight SQL 
execution paths.
   
   ### Component(s)
   
   Integration


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to