shaoting-huang opened a new issue, #31: URL: https://github.com/apache/arrow-go/issues/31
### Describe the enhancement requested [WithEncoding](https://github.com/apache/arrow/blob/21238a7f5ebb224410d84ecf32dbe3556cab363a/go/parquet/writer_properties.go#L192) comments are misleading users now. ``` // WithEncoding defines the encoding that is used when we aren't using dictionary encoding. // // This is either applied if dictionary encoding is disabled, or if we fallback if the dictionary // grew too large. func WithEncoding(encoding Encoding) WriterProperty { return func(cfg *writerPropConfig) { if encoding == Encodings.PlainDict || encoding == Encodings.RLEDict { panic("parquet: can't use dictionary encoding as fallback encoding") } cfg.wr.defColumnProps.Encoding = encoding } } ``` Currently, Go parquet fallback encoding is hardcoded as plain encoding. See [fallbackToPlain](https://github.com/apache/arrow/blob/21238a7f5ebb224410d84ecf32dbe3556cab363a/go/parquet/file/column_writer.go#L67). It is better to support custom fallback encoding. ### Component(s) Go, Parquet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
