rustyconover opened a new issue, #973: URL: https://github.com/apache/arrow-nanoarrow/issues/973
`TestingJSONComparison` (`src/nanoarrow/testing/testing.cc`) does not compare the metadata of nested child fields. Field metadata is compared for top-level fields, but metadata on the children of struct, list, map or union fields is not. So a consumer that drops metadata on a nested child (e.g. an extension type on a list item) still passes the integration comparison. This came up while adding dictionary value metadata comparison for #972, which compares `ArrowSchema.dictionary->metadata` at any depth but leaves child field metadata as it was. Comparing child metadata the same way would close the gap. Note that empty and absent metadata should probably be treated as equal there too, since IPC and the integration JSON both omit empty metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
