gemmellr commented on code in PR #6120:
URL: https://github.com/apache/artemis/pull/6120#discussion_r2607623831
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/VersionedBase.java:
##########
@@ -31,6 +31,21 @@ public abstract class VersionedBase extends ClasspathBase {
protected final ClassLoader senderClassloader;
protected final ClassLoader receiverClassloader;
+ // for tests that don't use a server classLoader
+ public VersionedBase(String sender, String receiver) throws Exception {
+ this.sender = sender;
+ this.receiver = receiver;
+ this.senderClassloader = getClasspath(sender);
+ this.receiverClassloader = getClasspath(receiver);
+ clearGroovy(senderClassloader);
+ clearGroovy(receiverClassloader);
+
+ // on the case of server not being used, we will set it as the same as
sender
+ // as some scripts will need it set to verify versioning
+ this.server = sender;
+ this.serverClassloader = senderClassloader;
Review Comment:
Which scripts? Can they not be changed to _not_ require something be
magically set when they didnt say they are using it (quite the reverse, if
calling this constructor) ? The other bits are a significant improvement but
this bit seems as confusing, or possibly more, as before in the other
constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
