[
https://issues.apache.org/jira/browse/ARTEMIS-5808?focusedWorklogId=995606&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-995606
]
ASF GitHub Bot logged work on ARTEMIS-5808:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/25 17:40
Start Date: 10/Dec/25 17:40
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #6120:
URL: https://github.com/apache/artemis/pull/6120#discussion_r2607623831
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/VersionedBase.java:
##########
@@ -31,6 +31,21 @@ public abstract class VersionedBase extends ClasspathBase {
protected final ClassLoader senderClassloader;
protected final ClassLoader receiverClassloader;
+ // for tests that don't use a server classLoader
+ public VersionedBase(String sender, String receiver) throws Exception {
+ this.sender = sender;
+ this.receiver = receiver;
+ this.senderClassloader = getClasspath(sender);
+ this.receiverClassloader = getClasspath(receiver);
+ clearGroovy(senderClassloader);
+ clearGroovy(receiverClassloader);
+
+ // on the case of server not being used, we will set it as the same as
sender
+ // as some scripts will need it set to verify versioning
+ this.server = sender;
+ this.serverClassloader = senderClassloader;
Review Comment:
Which scripts? Can they not be changed to _not_ require something be
magically set when they didnt say they are using it (quite the reverse, if
calling this constructor) ? The other bits are a significant improvement but
this bit seems as confusing, or possibly more, as before in the other
constructor.
Issue Time Tracking
-------------------
Worklog Id: (was: 995606)
Time Spent: 20m (was: 10m)
> CompatiblityTests: Make cases where serverClassLoader==null clearer
> -------------------------------------------------------------------
>
> Key: ARTEMIS-5808
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5808
> Project: Artemis
> Issue Type: Test
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.45.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Some tests are not using the server's classLoader.. just a classLoader to
> produce data, and another to receive data.
> It would be clearer if we added a new constructor so it's clear the intention
> in the tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
