gemmellr commented on code in PR #148:
URL: https://github.com/apache/artemis-console/pull/148#discussion_r2610223100
##########
artemis-console-extension/artemis-extension/packages/artemis-console-plugin/src/queues/CreateQueue.tsx:
##########
@@ -160,7 +160,7 @@ export const CreateQueue:
React.FunctionComponent<CreateQueueProps> = (props: Cr
</FormGroup>
<FormGroup label="Filter"
labelIcon={
- <Tooltip content={<Text>Only messages that match the
filter expression are routed to this queue: see <a
href="https://activemq.apache.org/components/artemis/documentation/latest/filter-expressions.html";
rel="noreferrer" target="_blank">Filter
Expressions</a></Text>}><InfoCircleIcon /></Tooltip>}
+ <Tooltip content={<Text>Only messages that match the
filter expression are routed to this queue: see <a
href="https://artemis.apache.org/documentation/latest/filter-expressions.html";
rel="noreferrer" target="_blank">Filter Expressions</a></Text>}><InfoCircleIcon
/></Tooltip>}
Review Comment:
```suggestion
<Tooltip content={<Text>Only messages that match the
filter expression are routed to this queue: see <a
href="https://artemis.apache.org//components/artemis/documentation/latest/filter-expressions.html";
rel="noreferrer" target="_blank">Filter
Expressions</a></Text>}><InfoCircleIcon /></Tooltip>}
```
##########
Releasing.md:
##########
@@ -53,9 +53,9 @@ When prompted make sure the new development version matches
with the next expect
```
[INFO] Checking dependencies and plugins for snapshots ...
-What is the release version for "ActiveMQ Artemis Console Project"?
(artemis-console-project) 1.0.0: :
-What is the SCM release tag or label for "ActiveMQ Artemis Console Project"?
(artemis-console-project) 1.0.0: :
-What is the new development version for "ActiveMQ Artemis Console Project"?
(artemis-console-project)1.0.1-SNAPSHOT: : 1.1.0-SNAPSHOT
+What is the release version for "Artemis Console Project"?
(artemis-console-project) 1.0.0: :
+What is the SCM release tag or label for "Artemis Console Project"?
(artemis-console-project) 1.0.0: :
+What is the new development version for "Artemis Console Project"?
(artemis-console-project)1.0.1-SNAPSHOT: : 1.1.0-SNAPSHOT
Review Comment:
From the pom changes I think it will probably be "Apache Artemis Console
Project"
```suggestion
What is the release version for "Apache Artemis Console Project"?
(artemis-console-project) 1.5.0: :
What is the SCM release tag or label for "Apache Artemis Console Project"?
(artemis-console-project) 1.5.0: :
What is the new development version for "Apache Artemis Console Project"?
(artemis-console-project)1.5.1-SNAPSHOT: : 1.6.0-SNAPSHOT
```
##########
artemis-console-extension/artemis-extension/app/public/hawtconfig.json:
##########
@@ -2,23 +2,23 @@
"branding": {
"appName": "Artemis Console",
"showAppName": false,
- "appLogoUrl": "img/activemq.png",
- "companyLogoUrl": "img/activemq.png",
- "css": "css/activemq.css"
+ "appLogoUrl": "img/artemis.png",
+ "companyLogoUrl": "img/artemis.png",
+ "css": "css/artemis.css"
},
"login": {
"description": "Login page for Artemis Console.",
"links": [
- { "url":
"https://activemq.apache.org/components/artemis/documentation/";, "text":
"Documentation" },
- { "url": "https://activemq.apache.org/";, "text": "Website" }
+ { "url":
"https://artemis.apache.org/components/artemis-console/documentation/";, "text":
"Documentation" },
Review Comment:
The idea of this link was as a substitute for the previously-embedded broker
documentation.
I think this change makes sense though, since this is the standalone console
release and these docs show how to use that, which is different.
Since the broker embedded version has its own configuration, we can still
then override/set the documentation link in the broker-embedded version
pointing at the main broker documentation page as before, right?
##########
artemis-console-extension/artemis-extension/app/public/index.html:
##########
@@ -20,11 +20,11 @@
<head>
<meta charset="utf-8" />
<base href="/console/" />
- <meta name="description" content="ActiveMQ Artemis Management Console" />
+ <meta name="description" content="Apache Artemis Management Console" />
<!-- Hawtio branding styles and favicon placeholders -->
<link id="branding" rel="stylesheet" type="text/css" href="" />
- <link id="favicon" rel="icon" type="image/x-icon" href="img/favicon.ico" />
+ <link id="favicon" rel="icon" type="image/x-icon" href="img/favicon.png" />
Review Comment:
Seems like it should be:
```suggestion
<link id="favicon" rel="icon" type="image/png" href="img/favicon.png" />
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
