jbertram opened a new pull request, #6149:
URL: https://github.com/apache/artemis/pull/6149
I'm removing all the HTTP-specific idle connection functionality for 2
reasons:
- the client-side keep-alive mechanism is completely broken
- this duplicates the pinging functionality already in the Core protocol
When the client-side sends an HTTP request for keep-alive purposes, it sends
a GET. The broker only handles POST requests and therefore throws a
ClassCastException causing the connection to fail. This appears to have been
broken for a long time.
Furthermore, both the client-side and broker-side HTTP-specific keep-alive
code appears to be completely unnecessary. When httpEnabled=true the Core
client simply tunnels it's normal packets through HTTP requests, including the
normal ping packets to & from the broker. There is no need to have another
keep-alive mechanism assuming the client configures their
clientFailureCheckPeriod and connectionTTL appropriately. I can only assume
this code was added for a defunct use-case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
