[ 
https://issues.apache.org/jira/browse/ARTEMIS-5850?focusedWorklogId=1001416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1001416
 ]

ASF GitHub Bot logged work on ARTEMIS-5850:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jan/26 17:40
            Start Date: 22/Jan/26 17:40
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on code in PR #158:
URL: https://github.com/apache/artemis-console/pull/158#discussion_r2717925132


##########
artemis-console-website/pom.xml:
##########
@@ -0,0 +1,101 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+   <modelVersion>4.0.0</modelVersion>
+
+   <parent>
+      <groupId>org.apache.artemis</groupId>
+      <artifactId>artemis-console-project</artifactId>
+      <version>1.6.0-SNAPSHOT</version>
+   </parent>
+
+   <artifactId>artemis-console-website</artifactId>
+   <packaging>jar</packaging>
+   <name>Apache Artemis Console Website</name>
+
+   <properties>
+      <skipWebsiteDocGeneration>false</skipWebsiteDocGeneration>
+      
<asciidoctor.maven.plugin.version>3.2.0</asciidoctor.maven.plugin.version>
+   </properties>
+
+   <profiles>
+      <profile>
+         <id>release</id>
+         <build>
+            <plugins>
+               <plugin>
+                  <groupId>org.asciidoctor</groupId>
+                  <artifactId>asciidoctor-maven-plugin</artifactId>
+                  <version>${asciidoctor.maven.plugin.version}</version>
+                  <executions>
+                     <execution>
+                        <id>generate-user-manual-html</id>
+                        <phase>generate-sources</phase>
+                        <goals>
+                           <goal>process-asciidoc</goal>
+                        </goals>
+                        <configuration>
+                           
<sourceDirectory>${project.basedir}/../docs/user-manual</sourceDirectory>
+                           
<outputDirectory>${project.build.directory}/user-manual</outputDirectory>

Review Comment:
   This probably means that they are outwith the content for the produced jar, 
which will then be empty other than an embedded Maven pom + properties. 
Switching the property to ${project.build.outputDirectory} should probably work.



##########
docs/user-manual/fonts/LICENSE-font-awesome-fonts.txt:
##########
@@ -0,0 +1,97 @@
+# Fonts: SIL OFL 1.1 License

Review Comment:
   Should be a reference added in the main LICENCE file (see the main Artemis 
file for example).



##########
docs/user-manual/css/LICENSE-font-awesome-css.txt:
##########
@@ -0,0 +1,23 @@
+# Code: MIT License (https://opensource.org/licenses/MIT)

Review Comment:
   Should be a reference added in the main LICENCE file (see the main Artemis 
file for example).





Issue Time Tracking
-------------------

    Worklog Id:     (was: 1001416)
    Time Spent: 3h 10m  (was: 3h)

> Consolidate web console docs
> ----------------------------
>
>                 Key: ARTEMIS-5850
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5850
>             Project: Artemis
>          Issue Type: Task
>          Components: Documentation
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Currently documentation for the web console is in 2 places:
> * 
> https://github.com/apache/artemis-website/tree/main/src/components/artemis-console/documentation
> * 
> https://github.com/apache/artemis/blob/main/docs/user-manual/management-console.adoc
> Each set of documentation has information that the other set doesn't as well 
> as significant overlap. This documentation should be consolidated with a 
> preference for the AsciiDoc format since it's superior to Markdown in this 
> context.
> Also, the docs needs to be updated to account for new functionality and 
> behavior introduced in recent versions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to