gtully commented on code in PR #6199:
URL: https://github.com/apache/artemis/pull/6199#discussion_r2736657271
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImplTest.java:
##########
@@ -3033,6 +3034,16 @@ public void
testSecuritySettingPluginFromBrokerProperties() throws Exception {
assertTrue(configuration.getStatus().contains("initialContextFactory"));
}
+ @Test
+ public void testExportInvalidPropertyOnAcceptor() throws Exception {
+ ConfigurationImpl configuration = new ConfigurationImpl();
+
+ // useKQueue here would generate a hashMap Value null, what would break
the exportAsProperties.
+ configuration.addAcceptorConfiguration("test",
"tcp://0.0.0.0:61616?useKQueue");
+ File fileOutput = new File(getTestDirfile(), "broker.properties");
+ assertDoesNotThrow(() -> configuration.exportAsProperties(fileOutput));
Review Comment:
for sure should not throw, but should not loose info... I think it should be:
...params.useKQueue=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
