[
https://issues.apache.org/jira/browse/ARTEMIS-5861?focusedWorklogId=1002710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1002710
]
ASF GitHub Bot logged work on ARTEMIS-5861:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/26 17:01
Start Date: 30/Jan/26 17:01
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #6202:
URL: https://github.com/apache/artemis/pull/6202#discussion_r2747172535
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java:
##########
@@ -865,10 +865,10 @@ public synchronized void pause() {
// We *pause* the acceptor so no new connections are made
if (serverChannelGroup != null) {
if (!serverChannelGroup.close().awaitUninterruptibly(shutdownTimeout,
TimeUnit.MILLISECONDS)) {
Review Comment:
I think we should only wait for the close in the presence of a
shutdownTimeout > 0, in that way we won't warn unless the caller cares about
the outcome.
Issue Time Tracking
-------------------
Worklog Id: (was: 1002710)
Time Spent: 1h 40m (was: 1.5h)
> Netty acceptor not shutting down
> --------------------------------
>
> Key: ARTEMIS-5861
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5861
> Project: Artemis
> Issue Type: Bug
> Affects Versions: 2.44.0
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Thread dump analysis reveals that the broker hangs indefinitely when trying
> to close Netty channel groups in a Netty acceptor, e.g.:
> {noformat}
> State: WAITING (on object monitor)
> Stack trace:
> at
> io.netty.util.concurrent.DefaultPromise.awaitUninterruptibly(DefaultPromise.java:290)
> - locked <0x00000000dbd095a8> (a
> io.netty.channel.group.DefaultChannelGroupFuture)
> at
> io.netty.channel.group.DefaultChannelGroupFuture.awaitUninterruptibly(DefaultChannelGroupFuture.java:178)
> at
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor.asyncStop(NettyAcceptor.java:793){noformat}
>
> The code at {{NettyAcceptor.java:793}} calls
> {{channelGroup.close().awaitUninterruptibly()}} without a timeout parameter
> causing indefinite hang when channels fail to close properly. This problem is
> very rare and there is no good reproducer
> The broker should complete shutdown within a reasonable timeout period,
> forcefully closing any remaining connections if necessary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
