gemmellr commented on PR #6205:
URL: https://github.com/apache/artemis/pull/6205#issuecomment-3847116814
> @gemmellr I peeked at the image example tests, none have overlapping
re-loadable config. I cannot find any broken usage in our test suite.
The config doesnt actually need to 'overlap' for it to be a problem, its
arguably even more of an issue when it doesnt as then the original certainly
shouldnt be getting tossed.
The issue is also not going to be contained to our test suite.
We provide multiple APIs that allow providing Configuration objects, even
encourage it, or always do it. Your changes dont even try to stop that, they'll
just make it _silently_ do something _egregiously different_ than before.
> @gemmellr I peeked at the image example tests, none have overlapping
re-loadable config. I cannot find any broken usage in our test suite.
Again, this is not an issue contained to our test suite.
Check out the main ActiveMQServerImpl constructors, or the 'Main' which do
supply a Configuration, or EmbeddedActiveMQ which it uses and similarly can or
will do the same, and is used in various other places to that end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
