gemmellr commented on PR #6228: URL: https://github.com/apache/artemis/pull/6228#issuecomment-3886068254
I didnt really like the idea of this since folks may have existing setups that use 17 / 21 with it enabled currently and will then silently no longer get these checks even though they may still think they are (the build time difference, and lack of log spam, would be hints...but still not everyone will spot it changing). Of course, I didnt particularly like any of the alternatives either (such as making it fail in those cases, or even using different versions for different JDKs, and they hadnt even done the 'requires additional flag for JDK21' change last time I looked either) which is why I hadnt done anything about it since #5824. Hmm.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
