gnodet opened a new pull request, #6286: URL: https://github.com/apache/artemis/pull/6286
## Summary - `ActiveMQServers.newActiveMQServer(String, MBeanServer, ActiveMQSecurityManager)` was calling the 3-arg `newActiveMQServer(Configuration, MBeanServer, SecurityManager)` which hardcodes `enablePersistence=true`, overriding whatever was parsed from XML (e.g. `<persistence-enabled>false</persistence-enabled>`) - Changed to call the 4-arg version with `config.isPersistenceEnabled()` to preserve the XML setting - Added a unit test that verifies `persistence-enabled=false` from XML config is respected ## Test plan - [x] New unit test `ActiveMQServersTest.testNewActiveMQServerFromConfigURLRespectsXmlPersistenceEnabled` passes - [ ] Existing tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
