[
https://issues.apache.org/jira/browse/ARTEMIS-5607?focusedWorklogId=1009123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1009123
]
ASF GitHub Bot logged work on ARTEMIS-5607:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/26 15:31
Start Date: 11/Mar/26 15:31
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #6278:
URL: https://github.com/apache/artemis/pull/6278#issuecomment-4040056300
@hyperxpro, this looks good overall. Nice work! That said, there are a few
items that need attention:
1. The commit message should reference the Jira. See
[here](https://artemis.apache.org/components/artemis/documentation/hacking-guide/#commitMessageDetails).
2. There is no test that verifies the behavior. I think even a simple unit
test that verifies `broadcast` is `null` or not when creating an instance of
`ManagementServiceImpl` would be sufficient.
3. I realize now that using the term "mirrors" in Jira description was a
mistake because we already have a mirroring feature in the broker and this may
cause confusion. You've used this term throughout the JavaDoc and commit
message. I think using something like "reproduces" (and variants) would be more
clear.
Issue Time Tracking
-------------------
Worklog Id: (was: 1009123)
Time Spent: 20m (was: 10m)
> Support disabling JMX notifications
> -----------------------------------
>
> Key: ARTEMIS-5607
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5607
> Project: Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [JMX
> notifications|https://docs.oracle.com/en/java/javase/17/docs/api/java.management/javax/management/Notification.html]
> are rarely used these days yet the broker still mirrors all management
> notifications as JMX notifications. This is unnecessary overhead in most
> circumstances so we should allow users to disable them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
